On https://qa.drupal.org/pifr/test/785388 we ran into an issue because CommentDefaultFormatterCacheTagsTest is not using the right way to set the current user.

CommentFileSizeAuthor
#1 comment-2263329-1.patch1.04 KBdawehner

Comments

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new comment-2263329-1.patch1.04 KB

Here is a fix.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Reviewed & tested by the community

We should get a follow-up to fix this for the other places this is done, but they don't actually go near a typehint for AccountProxy, so they are not critical.

dawehner’s picture

dawehner
Primary language German
commented
Related issues: +#2263339: Fix all current_user set calls
dawehner’s picture

dawehner
Primary language German
commented
Issue tags: +Quickfix

.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed
Issue tags: -Quickfix +Quick fix

Good catch.

Committed and pushed to 8.x. Thanks!

  • Commit 3da1bdf on 8.x by webchick: 
    Issue #2263329 by dawehner: CommentDefaultFormatterCacheTagsTest just...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.