Since we move the config into the db and stopped using CachedStorage we only use cache.config for storing a key will all the schema. This seems wasteful.

Plus it gets in the way of refactoring CachedStorage to support collections see #2262861: Add concept of collections to config storages

Making a major and not a beta blocker since it makes the patch on #2262861: Add concept of collections to config storages smaller and easier to understand.

CommentFileSizeAuthor
#2 2263255.2.patch2.39 KBalexpott
cache-config-removal.patch2.38 KBalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented

cache schema is basically a plugin cache, those all switched to cache.discovery, feels a bit weird but should we do that too?

We won't need this on normal page requests, so there's no need to put it into APC/FileStorage like the others, but it might be more consistent?

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
FileSize
2263255.2.patch2.39 KB

Makes sense to me.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Needs review » Reviewed & tested by the community

Looks good. Not mentioned here, but the new collection-supporting cached storage will use cache bins dynamically, so we won't need the hardcoded definition anymore.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

  • Commit c2ffb7b on 8.x by webchick: 
    Issue #2263255 by alexpott: Cache.config only has a single key in it for...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.