Title says it all. Visibility keywords are missing and our coding standard requires them.

CommentFileSizeAuthor
#4 2261465-4.patch649 bytesrpayanm
#2 2261465-2.patch1009 bytesrpayanm
missing_KernelTest_visibility.patch1003 bytesneclimdul
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

znerol’s picture

znerol CreditAttribution: znerol commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

Meanwhile setUp() has become protected in HEAD (#2322889: Various setUp() and tearDown() methods are not protected). Needs reroll.

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
CreditAttribution: rpayanm commented
Status: Needs work » Needs review
FileSize
2261465-2.patch1009 bytes
znerol’s picture

znerol CreditAttribution: znerol commented
Status: Needs review » Needs work

Thanks.

+++ b/core/modules/system/src/Tests/DrupalKernel/DrupalKernelTest.php
@@ -19,7 +19,7 @@
-  protected function setUp() {
+  public function setUp() {

It is okay for the setUp() function to be protected here because this is not a PHPUnit test. No need to change that.

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
CreditAttribution: rpayanm commented
Status: Needs work » Needs review
FileSize
2261465-4.patch649 bytes

thank you :)
fixed.

znerol’s picture

znerol CreditAttribution: znerol commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs reroll

Perfect, thanks.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed d07587e and pushed to 8.0.x. Thanks!

  • alexpott committed d07587e on 8.0.x 
    Issue #2261465 by rpayanm, neclimdul: Fixed Missing visibility keywords...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.