Will there be any?

Comments

Dave Cohen’s picture

Yes, eventually. Patches are welcome, if anyone wants to help. It's a small module and may not need much to upgrade.

NancyDru’s picture

StatusFileSize
new3.86 KB

Actually, here's a patch. I've done the Drupal part, but the jQuery needs attention and I don't know that part.

NancyDru’s picture

Assigned:Unassigned» NancyDru
Status:Active» Needs review
StatusFileSize
new3.94 KB

Scratch that one, I missed two small things. Now this completely works on 6.x.

deselaers’s picture

Hi,

I have applied this patch, and now hovertip seems to be working fine in my Drupal 6.1 installation.

Cheers,
thomas

wayland76’s picture

Title:6.x support?» Porting hovertips to 6.x

Dave, is there any chance you could commit this patch?

wayland76’s picture

(After branching CVS appropriately, of course)

NancyDru’s picture

And doing more testing? Someone else testing and marking RTBC would be nice.

wayland76’s picture

Hmm. Doesn't seem to work quite right.

http://www.housingaffordabilityaustralia.com/content/hovertips-test

I'm using the chameleon theme that comes with D6. In firefox, the hovertip comes up any time I'm over that window, rather than just when I hover over the appropriate text. Maybe I'm doing something wrong too, which is why I'm posting the link here.

wayland76’s picture

Ok, maybe it does, and I'm wrong. I finally got the Glossary and Hovertips working together here, and they seem to work properly :).

wayland76’s picture

Status:Needs review» Reviewed & tested by the community

...so I guess what I'm saying is, the patch is fine, but the documentation could probably use some work :).

wayland76’s picture

Status:Reviewed & tested by the community» Needs work

Ok, I've found a problem -- hovertips are only working if I'm logged in as Administrator, not anonymous. That's no reason not to create a 6.x dev branch, though :).

NancyDru’s picture

6.x has a new version of jQuery, and I suspect there is some tweaking required, but I don't know how to do that part.

wayland76’s picture

NancyDru’s picture

I know about the docs, but I am not a jQuery or js person.

wayland76’s picture

@NancyDru: Sorry, that wasn't directed at you, but more at someone who wants to get in and give this problem a shot.

Dave Cohen’s picture

I think the new version of jquery could make hovertip.js shorter (because I think jquery provides some of the coordinate nastiness in there now) although I'm not certain about that.

I've been sluggish to check in an Drupal 6 changes because personally I have not yet upgraded any of my sites. I will get to this, though! I appreciate the help.

NancyDru’s picture

I've only got my one test site so far, and it is not a really good test bed yet. I have most of my modules converted, but the jQuery is beyond me at the moment. Sorry I couldn't do that part too.

jhedstrom’s picture

StatusFileSize
new3.92 KB

I resolved the issue with non-admin users being able to see the tips. The problem was in hovertip_menu, in that apparently access arguments can't simply be array(TRUE). I set it to array('access content').

I also reviewed the js, and it didn't look like it needed any updating.

NancyDru’s picture

They can be, but I may not have done it properly. AFAIC, that's a good solution - if they can't see content, then why are they even on the site.

jhedstrom’s picture

They can be, but I may not have done it properly.

I assume it can be done, I just couldn't figure out how to do it via the Drupal API.

I suppose one could simple change the "access callback" to "is_array" and pass in "array(1)", but this seems hacky at best.

NancyDru’s picture

I remember running across it somewhere in the upgrade docs, but don't remember where right now.

wayland76’s picture

@Dave: Can we at least have a dev branch for this? If you need help with the release system (including CVS), I can help with that (I assume you don't need this, but since there's been no 1.x version, I thought I'd offer).

wayland76’s picture

@jhedstrom: what is this patch against?

NancyDru’s picture

My base was: $Id: hovertip.module,v 1.3 2007/12/12 19:23:34 yogadex Exp $

wayland76’s picture

StatusFileSize
new3.65 KB

Ok, here's mine against current HEAD, which Dave is updating for the first time since last year. Hopefully he'll be willing to branch for 6.x :).

wayland76’s picture

Assigned:NancyDru» Unassigned
Status:Needs work» Needs review

Forgot to change status; sorry. Nancy implied that she'd done as much as she could on it, so I'm reassigning it to no-one.

Dave Cohen’s picture

Status:Needs review» Fixed

Thanks everyone for your work on this. And also for your patience.

Sadly, I'm stuck in the Drupal 5.x world for every site I'm working on. So setting up my environment for 6.x has been something of a hurdle. I don't want to delay you any further so I've checked in the patch - without testing it. Something I'm loathe to do, but just resurrect this issue if I've blundered.

http://drupal.org/node/259042

Anonymous’s picture

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.