The new "Spinner" widget included in jQuery UI includes both a JS file and a CSS file, but only the JS file is added to the page currently. This patch adds the missing CSS file to the page as well.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug
Unfrozen changes Unfrozen because it only changes a library declared by core to include default CSS to accompany the already-included js
CommentFileSizeAuthor
#5 jquery-ui-spinner-css-2254319-05.patch448 bytesjhedstrom
#3 Content__Content____Site-Install-without.png177.48 KBjhedstrom
#3 Content__Content____Site-Install.png184.65 KBjhedstrom
#2 jquery_ui_spinner_css-2254319.patch440 bytesquicksketch
jquery_ui_spinner_css.patch579 bytesquicksketch

Comments

Status: Needs review » Needs work

The last submitted patch, jquery_ui_spinner_css.patch, failed testing.

quicksketch’s picture

quicksketch
he/him
commented
Status: Needs work » Needs review
StatusFileSize
new jquery_ui_spinner_css-2254319.patch440 bytes

Heh, last patch was against something from February. This one makes the same change in core.libraries.yml.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs manual testing
StatusFileSize
new Content__Content____Site-Install.png184.65 KB
new Content__Content____Site-Install-without.png177.48 KB

Patch applies with fuzz, and this adds missing css for a library declared by core.

I've updated the issue summary to include the beta phase evaluation.

To test, I added the spinner library to the views ui. Here is what it looks like with the CSS:

and here is how it looks without the CSS included:

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: jquery_ui_spinner_css-2254319.patch, failed testing.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Needs work » Needs review
Issue tags: -Needs manual testing
StatusFileSize
new jquery-ui-spinner-css-2254319-05.patch448 bytes

l'sigh, I thought testbot could apply patches with fuzz. Here's a reroll.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Needs review » Reviewed & tested by the community

Bouncing back to RTBC since the above was just a reroll to make the testbot go green.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 5: jquery-ui-spinner-css-2254319-05.patch, failed testing.

Status: Needs work » Needs review

jhedstrom queued 5: jquery-ui-spinner-css-2254319-05.patch for re-testing.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Needs review » Reviewed & tested by the community

Seriously testbot!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Good catch.

Committed and pushed to 8.0.x. Thanks!

  • webchick committed b97a591 on 8.0.x 
    Issue #2254319 by quicksketch, jhedstrom: jQuery UI Spinner CSS file not...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.