Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
The new "Spinner" widget included in jQuery UI includes both a JS file and a CSS file, but only the JS file is added to the page currently. This patch adds the missing CSS file to the page as well.
Beta phase evaluation
Issue category | Bug |
---|---|
Unfrozen changes | Unfrozen because it only changes a library declared by core to include default CSS to accompany the already-included js |
Comment | File | Size | Author |
---|---|---|---|
#5 | jquery-ui-spinner-css-2254319-05.patch | 448 bytes | jhedstrom |
#2 | jquery_ui_spinner_css-2254319.patch | 440 bytes | quicksketch |
Comments
Comment #2
quicksketchHeh, last patch was against something from February. This one makes the same change in core.libraries.yml.
Comment #3
jhedstromPatch applies with fuzz, and this adds missing css for a library declared by core.
I've updated the issue summary to include the beta phase evaluation.
To test, I added the spinner library to the views ui. Here is what it looks like with the CSS:
and here is how it looks without the CSS included:
Comment #5
jhedstroml'sigh, I thought testbot could apply patches with fuzz. Here's a reroll.
Comment #6
jhedstromBouncing back to RTBC since the above was just a reroll to make the testbot go green.
Comment #9
jhedstromSeriously testbot!
Comment #10
webchickGood catch.
Committed and pushed to 8.0.x. Thanks!