There are a couple of instances of EntityManager in constructors. Typehints on the interfaces to inject all the things.

CommentFileSizeAuthor
#4 drupal-EntityManager-typehints-2254001-31d1114-4.patch3.67 KBMixologic
#1 2254001-EntityManager-typehints-5c814d1-1.patch3.24 KBMixologic
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
CreditAttribution: Mixologic commented
FileSize
2254001-EntityManager-typehints-5c814d1-1.patch3.24 KB
Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
CreditAttribution: Mixologic commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 1: 2254001-EntityManager-typehints-5c814d1-1.patch, failed testing.

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
CreditAttribution: Mixologic commented
FileSize
drupal-EntityManager-typehints-2254001-31d1114-4.patch3.67 KB

geez. submit a patch, one commit goes in and it immediately needs a reroll.

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
CreditAttribution: Mixologic commented
Status: Needs work » Needs review
Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented

4: drupal-EntityManager-typehints-2254001-31d1114-4.patch queued for re-testing.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Status: Needs review » Reviewed & tested by the community

RTBC if the tests pass.

Thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 2ae0077 and pushed to 8.x. Thanks!

  • Commit 70ce81a on 8.x by alexpott: 
    Issue #2254001 by Mixologic: Use EntityMangagerInterface instead of...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.