I am getting the below on my update.php page:

Some of the pending updates cannot be applied because their dependencies were not met.

7219 - Remove Commerce Kickstart payment example and enable Commerce payment example.

This update will been skipped due to the following missing dependencies: commerce_discount_update_7104

Can't understand why, I don't even touch the discount stuff and I can't see where in the code 7104 is listed as a dependency of 7219 :S

CommentFileSizeAuthor
#9 commerce_kickstart.install.txt39.25 KBalexp999

Comments

lsolesen’s picture

Category: Support request » Bug report

The dependency is listed here:

http://drupalcode.org/project/commerce_kickstart.git/blob/refs/heads/7.x...

As you can see here --> without the dependency there will be an update error: https://travis-ci.org/lsolesen/commerce_kickstart/jobs/23965835

The update should be included in commerce_discount bundled with commerce_kickstart --> see here http://drupalcode.org/project/commerce_discount.git/blob/refs/heads/7.x-...

lsolesen’s picture

Category: Bug report » Support request
Status: Active » Postponed (maintainer needs more info)
lsolesen’s picture

alexp999’s picture

Just checked and commerce discount is not enabled.

I imagine that is why the update has not been run. Surely an update shouldn't be dependant on an update from another module, which itself is not a module dependency (required by).

lsolesen’s picture

Category: Support request » Bug report
Status: Postponed (maintainer needs more info) » Active
alexp999’s picture

I changed that bit for the dependency to the below:

  if (module_exists('commerce_discount')) {
    $deps['commerce_kickstart'][7219] = array(
      'commerce_discount' => 7104,
    );
  }

Which is the same as what was done around line 1132 for another update. Just updated without any errors :)

lsolesen’s picture

Yeah. I was thinking along the same lines. Could you create a patch - or should I author it?

londova’s picture

Hello,
Could you please describe how to pass this issue in a NON-technical language.
I have the dame issue, but didn't understand where an what should I change.
Thanks.

alexp999’s picture

StatusFileSize
new39.25 KB

@lsolesen

If you could create the patch, I have tried making patches before but cannot get them to output properly.

I have attached the complete file if it helps.

alexp999’s picture

Just noticed there is this in the dependency list too:

  $deps['commerce_kickstart'][7213] = array(
    'commerce_discount' => 7101,
    'commerce_discount' => 7102,
  );

I'm surprised I didn't get stuck on this one? Does this need to be included in the conditional?

tgeller’s picture

See also #2248025: Commerce Discount error prevents database update. Thanks to @lsolesen for connecting the dots.

lsolesen’s picture

Status: Active » Needs review

@alexp999 You should learn how to create a patch :) Here is a good explanation: https://drupal.org/node/707484

@alexp999 #10 That update has run in previous Kickstart versions, and the dependency has just been introduced in the 2.14 version.

If the tests passes for this pull request, this should be fixed.

https://github.com/commerceguys/commerce_kickstart/pull/46

lsolesen’s picture

Status: Needs review » Fixed

  • Commit 976fd74 on 7.x-2.x by bojanz:
    Merge pull request #46 from lsolesen/issue-2252847
    
    Issue #2252847 by...
  • Commit 9a2b74e on 7.x-2.x by lsolesen:
    Issue #2252847 by alexp999: Unmet depedency on update when...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.