Problem/Motivation

In a Guzzle issue on github mtdowling asked why Guzzle is not mentioned in the default user agent header in our implementation of the HTTP client. This is a good question, it would be more accurate to include both Drupal and Guzzle I think?

Proposed resolution

Add the default user agent string to our Drupal string.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#4 2251829-4.patch542 bytesdamiankloip
#1 2251829.patch516 bytesdamiankloip

Comments

damiankloip’s picture

damiankloip commented
Status: Active » Needs review
StatusFileSize
new 2251829.patch516 bytes
damiankloip’s picture

damiankloip commented
Title: Add Guzzle back to HTTP clients default user agent header » Add 'Guzzle' back to HTTP clients default user agent header
sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Unless I'm mistaken, there is a formal standard syntax for specifying multiple vendors (and optionally versions) in a User-Agent HTTP header — are you sure that a simple space is correct?

FWIW, the drupal.org URL should use HTTPS... ;) Do we want to fix that here in one go? :-)

damiankloip’s picture

damiankloip commented
StatusFileSize
new 2251829-4.patch542 bytes

We spoke about this on IRC, separating by a space is totally fine. We should prob add the version number too though.

Example header string with this patch: Drupal/8.0-dev (+https://drupal.org/) Guzzle/4.0.0 curl/7.30.0 PHP/5.5.11

Not doing an interdiff for a one line patch :)

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community

Thanks!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

  • Commit 519e01c on 8.x by webchick: 
    Issue #2251829 by damiankloip: Add 'Guzzle' back to HTTP clients default...
damiankloip’s picture

damiankloip commented

Nice, real User agent headers - thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.