Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
routing system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
25 Apr 2014 at 19:12 UTC
Updated:
3 Sep 2014 at 14:40 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
dawehner... In fact we just store the service ID to not have to figure out which authentication manager applies to which route at runtime. I would love to extend #2213319: Create a single Container CompilerPass to collect + add handlers to consumer service definitions to support service IDs as well.
Comment #2
dawehnerComment #4
dawehnerThis time it should actually work.
Comment #6
dawehnerFixed the failure.
Comment #8
tim.plunkettA welcome improvement.
Comment #9
chx commentedthis shouldn't hold the commit up but
that just rubs me the wrong way. Is there any reason not to put that in a comment and instead run a strlen every time this is ran? I know microoptimization and all but still, this is ridiculous (and if I am not mistaken this runs on every request). Do we expect that the length of the string
authentication.to change any time soon?Comment #10
sunAgreed, replaced accordingly.
Comment #11
dawehner+1 for this optimization. This runs at least on potentially every request, so its somehow worth.
Comment #12
alexpottCommitted a704796 and pushed to 8.0.x. Thanks!