system_sort_themes() should not say it's suitable for modules.

Thanks! yeah. Probably an @see to the module function and an update to the docs would be appropriate. It should follow the standards in: https://drupal.org/node/1354#callbacks

And this is 8.x also.

Changed the docblock: added the @see to system_sort_modules_by_info_name(), added the callback information.

1. +++ b/core/modules/system/system.module
   @@ -1370,7 +1370,12 @@ function system_sort_modules_by_info_name($a, $b) {
   + * Callback for uasort within
   

   s/uasort/uasort()/

2. +++ b/core/modules/system/system.module
   @@ -1370,7 +1370,12 @@ function system_sort_modules_by_info_name($a, $b) {
   + * @see system_sort_modules_by_info_name() for sorting modules.
   

   We just refer to functions, without additional information. The extra information can be found at that other function's documentation. So just

   @see function()
   

   is sufficient.

Fixed both remarks.

Looking to help finish up this issue tonight at a ladder sprint. I'm confused though, looks like patch 5 is failing but the issue was sent to community review? Am I missing something? Not sure where to pick up the issue.

The test failures are not related to this patch. Sometimes the test bot has problems. Ignore them.

Regarding the latest patch, it looks good to me except the first line, which says:

Array sorting callback; sorts themes by their name.

Please take out the "Array sorting callback;" part. It is not necessary, since the rest of the doc block explains that it is a callback.

@jhodgdon - Please review updated patch which takes out the "Array sorting callback;" part.

Thanks, that looks better!

Thanks again! Committed to 8.x. Needs backport to 7.x now.

Thanks @jhodgdon!

Please see patch for D7.

Thanks! The backport is correct, but I just noticed (doh!) that the function actually sorts themes with the default theme first, and then by name within the other non-default themes. So I think we should probably to back and fix the 8.x documentation and then return to 7.x. Just saying it sorts themes by name is not actually accurate.

Please review the updated patch for 8.x as per #16.

Thanks! But the first-line documentation for a function needs to be one line. See:
https://drupal.org/node/1354#drupal

How about:

Sorts themes by their names, with the default theme listed first.

Sounds much better!

Please review revised patch.

That works for me (not surprising). :)

Thanks again! Committed to 8.x.

We now need patch #14 updated with the text change in #19 for D7.

Thanks @jhodgdon!

Please see revised patch for D7 with the text change in #19.

Thanks!

Thanks again all! Committed to 7.x.