Contrib is starting to use field property definitions, for example Search API. Some labels that we currently have could be improved to be shorter or more specific. For example, entity references could use the entity type label as the label for the ->entity property instead of t('Entity'). Right now, in Search UI, you get something like Image > Entity > File URI.
Others are very long, like the image alt and title labels.
Go through property definition labels and improve them.
None in core as they are not displayed.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | property-labels-2248505-4.patch | 7.76 KB | leevingo |
| #1 | image_properties_after.png | 19.92 KB | berdir |
| #1 | image_properties_before.png | 32.67 KB | berdir |
| #1 | property-labels-2248505-1.patch | 8.01 KB | berdir |
Comments
Comment #1
berdirInitial patch, with before/after screenshots of Search API's UI.
Note: We have a somewhat strange pattern of naming the label for the ->value "Something value", like "Text value", "Float value", "Integer value" and so on. I already cleaned up a few of the really weird ones, like E-mail value or Comment status value, but many are left. Not sure what to do with them. When it's the only property then search api won't display it, but still..
Before:
After:
Comment #2
berdirTrying to get some feedback :)
Comment #3
Jalandhar commentedPatch needs reroll.
Comment #4
leevingo commentedRerolled patch, resolved 1 conflict in core/lib/Drupal/Core/Field/Plugin/Field/FieldType/EmailItem.php
I tried to test the patch but the current version of search_api (search_api 8.x-1.x-dev) doesn't work.
Comment #6
fagoThanks, new labels are definitely better. Moving longer stuff into the description also helps.
Comment #7
fagoComment #8
alexpottCommitted 82d059a and pushed to 8.0.x. Thanks!