Sub-task of #2231059: [meta] Find out what config schemas are still missing and add them

Problem/Motivation

[#1910624]introduced configuration schema + test coverage for schema for default configuration in core. However there are still few areas that doesn't have schema coverage.

Proposed resolution

Provide config schema for below configurations:

breakpoint.breakpoint_group.atestset
breakpoint.breakpoint.custom.user.

CommentFileSizeAuthor
#4 2245727.4.patch12.94 KBalexpott
#4 2-4-interdiff.txt5.3 KBalexpott
#2 2245727.2.patch9.93 KBalexpott

Comments

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Category: Task » Bug report

This is a bug in the breakpoint module - it should always have a consistent number of dots and therefore identifiers in the filename.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
StatusFileSize
new 2245727.2.patch9.93 KB

The id is made up of the name, source, and sourceType properties for both breakpoints and breakpoint groups. Source and sourceType have defaults. Therefore we should ensure that the name exists in the constructor.

Patch ensures that the name value is set and if not throws an exception. Tests are added for both breakpoint and breakpoint group entities.

Status: Needs review » Needs work

The last submitted patch, 2: 2245727.2.patch, failed testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs work » Needs review
StatusFileSize
new 2-4-interdiff.txt5.3 KB
new 2245727.4.patch12.94 KB

Fixed unit tests and move exception testing to said unit tests :)

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me! Let's get this in!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: 2245727.4.patch, failed testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 16,309 pass(es), 1,721 fail(s), and 3,814 exception(s).

Testbot what happened?

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs work » Needs review

4: 2245727.4.patch queued for re-testing.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Reviewed & tested by the community

Random fail.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

  • Commit f715886 on 8.x by webchick: 
    Issue #2245727 by alexpott | vijaycs85: Add missing configuration schema...
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Superb, thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.