template_preprocess_views_view_table ignores zero values

Thank you for the patch.

Moving to DEV as everything else is kinda pointless :) I wonder whether you could also write a patch.

StyleTableTest already has some tests which you can probably extend.

This adds a test that illustrates the bug, and the fix from above.

I also added a beta phase evaluation.

Those xpath tests were passing locally. I've updated them to be a bit more verbose to see if that makes the testbot happy.

Ok. This time, GREEN!

I marked #2171497: Table fields with the integer value zero are not displayed. as a duplicate. Both had a patch, the tests here also test the 'treat 0 as empty' option though.

+++ b/core/modules/views/views.theme.inc
@@ -573,7 +573,7 @@ function template_preprocess_views_view_table(&$variables) {
-        if (!empty($field_output) && empty($column_reference['content'])) {
+        if ((string) $field_output !== '' && empty($column_reference['content'])) {

Just curios, don't we have to take "empty_zero" on the field settings into account here?

Hmm, the test I added covers 'empty zero'. I think the reason the code in #19 doesn't need to worry about the 'empty zero' setting is that just below, there is a empty() check. The full code:

       // Only bother with separators and stuff if the field shows up.
        if ((string) $field_output !== '' && empty($column_reference['content'])) {
          // Place the field into the column, along with an optional separator.
          if (!empty($column_reference['content'])) {
            if (!empty($options['info'][$column]['separator'])) {
              $safe_content = SafeMarkup::escape($column_reference['content']);
              $safe_separator = Xss::filterAdmin($options['info'][$column]['separator']);
              $column_reference['content'] = SafeMarkup::set($safe_content . $safe_separator);
            }
          }
          else {
            $column_reference['content'] = '';
          }
          $safe_content = SafeMarkup::escape($column_reference['content']);
          $safe_field_output = SafeMarkup::escape($field_output);
          $column_reference['content'] = SafeMarkup::set($safe_content . $safe_field_output);
        }

Patch in #15 needed a reroll. This is that reroll.

Looks good to go to me though.

On 'empty zero': isn't that handled by the field handler? It is in Drupal\views\Plugin\views\field\Numeric anyway. So I'd say this level of the theme layer doesn't need to worry about it, let the field handler worry about it.

Not surprisingly, this doesn't apply anymore.

Somebody redid all the work in #2543132: Zero value not shown in views table style.