Problem/Motivation

When using filters being rendered inside a fieldset like date fields, the weight set to them isn't being taken into account. The fieldsets do not have a weight at all.

Proposed resolution

Remaining tasks

CommentFileSizeAuthor
#5 2242509-fieldset-weight-5.patch713 bytesmradcliffe
#4 2242509-fieldset-weight-4.patch666 bytesmradcliffe
#2 2242509-fieldset-weight-2.patch1.39 KBluksak
#1 2242509-fieldset-weight-1.patch2.21 KBluksak

Comments

luksak’s picture

luksak
he/him
commented
Status: Active » Needs review
StatusFileSize
new 2242509-fieldset-weight-1.patch2.21 KB

Attaching the patch that fixes the issue for me.

luksak’s picture

luksak
he/him
commented
StatusFileSize
new 2242509-fieldset-weight-2.patch1.39 KB

Forgot to remove some testing code...

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Version: 7.x-1.x-dev » 7.x-2.x-dev
Issue summary: View changes

I was still able to reproduce this in 7.x-2.x.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
StatusFileSize
new 2242509-fieldset-weight-4.patch666 bytes

Re-rolled patch for 7.x-2.x.

This seems to work for me, but the interface is still a little wonky with adjusting existing weights.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
StatusFileSize
new 2242509-fieldset-weight-5.patch713 bytes

Need to check when the filter is outside of a group as well and just set to 0.

  • mradcliffe committed 19590a5 on 7.x-2.x 
    Issue #2242509 by Lukas von Blarer, mradcliffe: Fixes weight of fields...
mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Needs review » Fixed

Fixed in 7.x-2.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.