FileTransfer::connect is protected yet the implementations are public and this is relied upon.

This issue has novice tasks. If you are an experienced core developer and have multiple commit mentions, please review novices' work on these tasks rather than doing them yourself. Feedback from experienced contributors is valued.

Problem/Motivation

+++ b/core/lib/Drupal/Core/FileTransfer/Form/FileTransferAuthorizeForm.php
@@ -0,0 +1,323 @@
+        $filetransfer->connect();

This can never work! the connect method is an abstract protected method! Looking at the implementations maybe they are somehow making it public... who knows? http://3v4l.org/08n7b interesting :) Opening a new issue to fix this.

Proposed resolution

Change \Drupal\Core\FileTransfer\FileTransfer::connect() to be abstract public.
Fix implementations (SSH and Local) to properly declare connect() as a public function.

Remaining tasks

• Write patch (novice)
• Review patch to check it fixes the issue, the change is properly documented and for coding standards. Provide test evidence (novice)
• Keep issue summary up to date (novice)

User interface changes

None

API changes

The abstract method becomes public - but the implementations already are :)