Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
language.module
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
15 Apr 2014 at 20:09 UTC
Updated:
19 Oct 2014 at 15:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
yesct commentedpostponed on #1987726: Convert language content page related callback to new style controller
Comment #2
mon_franco commentedComment #3
mon_franco commentedPatch is uploaded
Comment #4
mon_franco commentedComment #6
tstoecklerThanks for getting started on the patch!
I have one comment:
This comment should also be removed as part of the patch.
Comment #7
mon_franco commentedComment #8
mon_franco commentedI have looked at the next files:
And I have tried to find word "Save" and change it for "Save configuration"
Comment #9
mon_franco commentedComment #10
mon_franco commentedComment #12
alimac commentedComment #13
mon_franco commentedReroll. Some tests still fails, but better results now. I will continue tomorrow.
Comment #15
patrickd commentedcorrecting amsterdam tag (No space)
Comment #16
mon_franco commentedI have changed the file core/modules/path/src/Tests/PathLanguageTest.php because I made a mistake changing two buttons for edit nodes that should not be changed.
Comment #17
mon_franco commented@YesCT told me next suggestion after review the last patch (#16):
"The todo is saying to remove the override. so the comment will not be needed (when the override is removed)"
So I did it.
Comment #18
tstoecklerAwesomesauce!
Thanks a lot for your persistence @mon_franco!!!
Comment #19
mon_franco commentedComment #20
mon_franco commentedWe have found some errors by testing manually the issue
Comment #21
mon_franco commentedI have tested this issue manually and it works right as you can see on the screen shoots attached
Comment #22
yesct commentedok.. can't thing of anything that needs work here.
Comment #23
alexpottCommitted 08746e8 and pushed to 8.0.x. Thanks!