As part of #2124957: Replace 'content' cache tag with 'rendered' and use it sparingly, we added standardized cache tags to all entities in #2217749: Entity base class should provide standardized cache tags and built-in invalidation (with test coverage).
The DateFormat config entity type entity type affects rendered content all over the place: it's used pretty much everywhere. It seems appropriate in this case to not set cache tags that bubble up, but to just clear the entire render cache. Especially because it hardly ever changes: it's a set-and-forget thing.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | dateformat_cache_tags-2241275-10.patch | 754 bytes | wim leers |
Comments
Comment #1
wim leersComment #2
tstoecklerI think this makes sense.
However, I think we should improve the comment to say *why* we are doing this. I.e. that it's a performance improvement to have less tags.
Also shouldn't we override getCacheTag() to be a no-op?
Comment #3
wim leersAssigning to catch for feedback, before I develop this further.
Comment #4
catchI just posted on #2124957: Replace 'content' cache tag with 'rendered' and use it sparingly - should we continue there and postpone this one?
Comment #5
wim leersYes, let's block this on that.
Comment #6
catchComment #7
effulgentsia commented#4 is in.
Comment #10
wim leersComment #11
moshe weitzman commentedMakes sense to delete the whole render cache when date formats change. Better than adding cache tags to almost all cache entries. So, RTBC.
Comment #12
dries commentedCommitted to 8.x. Thanks.
Comment #14
wim leersNow that this one is in, let's get #2241267-3: Make tours set cache tags done!