Child of #2124749: [meta] Stop using $request->attributes->get(MAGIC_KEY) as a public API. Any ideas what to replace it with?

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

Instead #2214209: Move _menu_site_is_offine() into the Maintainance subscriber is in, we could maybe move this logic into a separate service you can ask whether you are in maintenance mode
and you could just set it to be in maintenance mode.

It could cache the information internally and clear it at the beginning of requests.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

Postponed on #2214209: Move _menu_site_is_offine() into the Maintainance subscriber

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Active » Postponed

.

ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented
Status: Postponed » Active

#1 sounds great to me

znerol’s picture

znerol CreditAttribution: znerol commented

Oops, missed that one, filed #2288665: Remove _maintenance request attribute and replace it with a maintenance mode service.

effulgentsia’s picture

effulgentsia CreditAttribution: effulgentsia commented
Status: Active » Closed (duplicate)

Nice! Since that issue has a working patch, closing this one as a duplicate.