Note this is (arguably) a bug report, but I didn't want to fight that fight, so tagging as 'task'.

This was originally found in #2177799: Allow IntegerItem's to be unsigned.

Problem/Motivation

setConstraints() overrides the entire list of constraints so it may remove previously set constraints. It should only be used in tests and when the entire list of constraints has previously been fetched with getConstraints()

Proposed resolution

- Replace usages of setConstraints() with addConstraint() where appropriate.
- Add a warning to the method doc.

Remaining tasks

User interface changes

None.

API changes

None.

CommentFileSizeAuthor
#3 2235125-3-set-vs-add-constraint.patch3.11 KBtstoeckler
#3 2235125-1-3-interdiff.txt776 byteststoeckler
#1 2235125-1-set-vs-add-constraint.patch3.12 KBtstoeckler

Comments

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Title: use DataDefinition::addConstraint() instead of ::setConstraints() » Use DataDefinition::addConstraint() instead of ::setConstraints()
Issue summary: View changes
Status: Active » Needs review
Parent issue: » #2177799: Allow IntegerItem's to be unsigned
StatusFileSize
new 2235125-1-set-vs-add-constraint.patch3.12 KB

Here we go.

Status: Needs review » Needs work

The last submitted patch, 1: 2235125-1-set-vs-add-constraint.patch, failed testing.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Needs work » Needs review
StatusFileSize
new 2235125-1-3-interdiff.txt776 bytes
new 2235125-3-set-vs-add-constraint.patch3.11 KB

Oops, too much copy and paste.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community

Thanks!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

  • Commit 83bdbd5 on 8.x by webchick: 
    Issue #2235125 by tstoeckler: Use DataDefinition::addConstraint()...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.