Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This should never have been put in Component.
Two issues exist to try to clean it up, but even with them it's not clear whether it could stay in Component.
#2043773: Replace php function wrappers in file.inc with a Drupal\Core\File\FileSystem class
#1673246: Adopt Lootils\Archiver
Comment | File | Size | Author |
---|---|---|---|
#5 | drupal-archiver-5.patch | 10.08 KB | ParisLiakos |
#5 | interdiff-2235099.txt | 2.31 KB | ParisLiakos |
#1 | archiver.patch | 10.47 KB | catch |
Comments
Comment #1
catchComment #2
Mile23It would be handy in /vendor, but...
https://github.com/pear/Archive_Tar/blob/master/Archive/Tar.php#L42
Ouch.
Comment #3
catchAlso we deliberately forked this when it first went in to use the drupal_* wrappers, pulling in the unforked PEAR library into vendor would be a functional regression.
Comment #4
catchComment #5
ParisLiakos CreditAttribution: ParisLiakos commentedyes lets move it already. like catch said removing the drupal_* wrappers there is a functional regression. and well with those there, they cant be in component, because the dependencies of those wrappers go down all the way to our stream wrapper system.
We need to open a followup to fix coding standards in ArchiverTar.php though.
I just rerolled it now, and replaced Implements... with {@inheritdoc} since we are touching them already
Comment #7
webchickCommitted and pushed to 8.x, but this really feels like stretching the definition of a critical. :)
Comment #9
catch@Angie it's actually the last issue from #1929270: [meta] Drupal-agnostic components should not be calling Drupal functions and allowed me to downgrade #2043773: Replace php function wrappers in file.inc with a Drupal\Core\File\FileSystem class to major.
The Component directory is a 'feature' of re-usable libraries. If you can't re-use them, then it is completely pointless to have the two directories.