http://bugs.php.net/bug.php?id=41125 was "Fixed in 5.2, 5.3 and HEAD." in 2008.

8.x requires php-5.4

so lets purge old unnecessary code.

CommentFileSizeAuthor
commit-php-old.patch591 bytesdanblack

Comments

danblack’s picture

danblack commented
Status: Active » Needs review
jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Needs review » Reviewed & tested by the community

Bug is indeed fixed in PHP long before 5.4. RTBC I think.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented

Actually, I'm unsure if this is allowed past beta or not?

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented

Useless code is a bug from a maintenance perspective and the impact seems to be very low (i.e. not existant, unless magically the PHP docs are completely off) so this seems fine IMO.

  • webchick committed eda7b8a on 8.0.x 
    Issue #2232881 by danblack: pdo used to require comment escaping - doesn...
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Agreed, thanks for catching this!

Committed and pushed to 8.0.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.