Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mikeytown2’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs backport to 7.x

This is a good idea. I was reviewing my slow query log and taxonomy_index showed up on it. Giving the table a primary key should help & these are the correct things to index. This needs to be backported to D7 as well. Patch looks good. The backport will be harder to do.

alexpott’s picture

Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed 1d198fb and pushed to 8.x. Thanks!

  • Commit 1d198fb on 8.x by alexpott:
    Issue #2232037 by danblack: Taxonomy_index should have a primary key.
    
fietserwin’s picture

Version: 7.x-dev » 8.x-dev
Status: Patch (to be ported) » Needs review

A (very little) bit of searching before creating this issue should have revealed issue #610076: Add a primary key to the {taxonomy_index} table and prevent duplicates being inserted.

I propose to revert this issue as it is going to lead to the integrity constraint violation errors because the cause of inserting duplicate entries (no language part in the key) still exists (AFAIK).

I cannot assign to @alexpott, so I hope he will read this anyway.

After reverting, we can close this as a duplicate and work on a complete solution in the other issue.

fietserwin’s picture

Status: Needs review » Reviewed & tested by the community

I guess that this status makes it more probable that this issue is going to be read.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, taxonomy_index_primary_key.patch, failed testing.

fietserwin’s picture

Component: database system » taxonomy.module
Status: Needs work » Fixed
Issue tags: -Needs backport to 7.x

This doesn't work, we leave this issue as is, the backport will be done in the other issue.

@danblack, @mikeytown2: can you review the patch in #610076: Add a primary key to the {taxonomy_index} table and prevent duplicates being inserted, so we can fix head!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.