Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
taxonomy.module
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
3 Apr 2014 at 05:19 UTC
Updated:
29 Jul 2014 at 23:31 UTC
Jump to comment: Most recent
Comments
Comment #1
mikeytown2 commentedThis is a good idea. I was reviewing my slow query log and taxonomy_index showed up on it. Giving the table a primary key should help & these are the correct things to index. This needs to be backported to D7 as well. Patch looks good. The backport will be harder to do.
Comment #2
alexpottCommitted 1d198fb and pushed to 8.x. Thanks!
Comment #4
fietserwinA (very little) bit of searching before creating this issue should have revealed issue #610076: Add a primary key to the {taxonomy_index} table and prevent duplicates being inserted.
I propose to revert this issue as it is going to lead to the integrity constraint violation errors because the cause of inserting duplicate entries (no language part in the key) still exists (AFAIK).
I cannot assign to @alexpott, so I hope he will read this anyway.
After reverting, we can close this as a duplicate and work on a complete solution in the other issue.
Comment #5
fietserwinI guess that this status makes it more probable that this issue is going to be read.
Comment #7
fietserwinThis doesn't work, we leave this issue as is, the backport will be done in the other issue.
@danblack, @mikeytown2: can you review the patch in #610076: Add a primary key to the {taxonomy_index} table and prevent duplicates being inserted, so we can fix head!