The follow up is to add www to the drupal.org link.

Problem/Motivation

I don't know if this is important or not. I have a website with a Powered by Drupal block in the footer. When attempting validation in http://validator.w3.org/checklink, they say

"The links below are not broken, but the document does not use the exact URL, and the links were redirected. It may be a good idea to link to the final location, for the sake of speed.
Line: 155 http://drupal.org/ redirected to https://drupal.org/
Status: 301 -> 200 OK
This is a permanent redirect. The link should be updated."

If it is important, here is his patch.

Proposed resolution

Contributor tasks needed
Task Novice task? Contributor instructions Complete?
Create a patch Novice Instructions
Manually test the patch Novice Instructions
Review patch to ensure that it fixes the issue, stays within scope, is properly documented, and follows coding standards Instructions

Remaining tasks

  • (novice) Write a patch for D8.
  • Review the Drupal 8 patch.

User interface changes

API changes

CommentFileSizeAuthor
#21 2231693-21.patch742 byteslinl
#15 interdiff-update_powered_by-2231693-15.txt1.04 KBjoshi.rohit100
#15 update_powered_by-2231693-15.patch1.19 KBjoshi.rohit100
#12 update_powered_by-2231693-12-D7.patch609 byteshelmo
#12 update_powered_by-2231693-12.patch737 byteshelmo
#8 powered_by_link_to_the_final_location-8-D7.patch605 bytesamitgoyal
#4 powered_by_link_to_the_final_location-4.patch732 bytesamitgoyal
powered_by_link_to_the_final_location.patch605 bytesItangSanjana

Comments

ItangSanjana’s picture

ItangSanjana commented
Status: Active » Needs review
dcam’s picture

dcam commented
Title: Powered by Drupal and W3C link checker » Update Powered by Drupal link
Version: 7.26 » 8.x-dev
Priority: Normal » Minor
Status: Needs review » Needs work
Issue tags: +Novice

This will have to be changed in Drupal 8 first.

dcam’s picture

dcam commented
Issue summary: View changes
amitgoyal’s picture

amitgoyal commented
Status: Needs work » Needs review
StatusFileSize
new powered_by_link_to_the_final_location-4.patch732 bytes

Please review attached patch for D8.

droplet’s picture

droplet commented
Status: Needs review » Reviewed & tested by the community

  • Commit c451db4 on 8.x by webchick: 
    Issue #2231693 by amitgoyal, iS: Update Powered by Drupal link.
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Nice catch!

Committed and pushed to 8.x. Thanks!

amitgoyal’s picture

amitgoyal commented
Version: 8.x-dev » 7.x-dev
Status: Fixed » Needs review
StatusFileSize
new powered_by_link_to_the_final_location-8-D7.patch605 bytes

Please review patch for D7 as well.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

The patch in #8 is the same as the patch provided in the original post.

The patch in the original post works for D7. After applying it the Powered by Drupal link changes to the https URL.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 8: powered_by_link_to_the_final_location-8-D7.patch, failed testing.

David_Rothstein’s picture

David_Rothstein commented
Status: Needs work » Reviewed & tested by the community

Likely testbot glitch - moving back to RTBC.

helmo’s picture

helmo commented
Version: 7.x-dev » 8.0.x-dev
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new update_powered_by-2231693-12.patch737 bytes
new update_powered_by-2231693-12-D7.patch609 bytes

We're now redirecting to www.drupal.org ... so core should update. Back to 8...

Here are patches for both D7 and D8

Status: Needs review » Needs work

The last submitted patch, 12: update_powered_by-2231693-12-D7.patch, failed testing.

dcam’s picture

dcam commented
Status: Needs work » Reviewed & tested by the community

Looks good. #12 is RTBC for 8.0.x.

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new update_powered_by-2231693-15.patch1.19 KB
new interdiff-update_powered_by-2231693-15.txt1.04 KB

updated patch as there should be $this->t() not t() method. Also I dont know whether we should use '@' in placeholder in t() or '!' ?

Status: Needs review » Needs work

The last submitted patch, 15: update_powered_by-2231693-15.patch, failed testing.

amitgoyal queued 15: update_powered_by-2231693-15.patch for re-testing.

The last submitted patch, 15: update_powered_by-2231693-15.patch, failed testing.

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
commented

Test failure says that "Unable to apply patch", but when I tried, patch applied successfully without any error.

helmo’s picture

helmo commented
Status: Needs work » Needs review

Please don't add unrelated changes. If t() needs to change then I expect there is a big issue to do it all at once.

The patch from #12still applies.

linl’s picture

linl commented
Title: Update Powered by Drupal link » [Follow up] Update Powered by Drupal link
Issue summary: View changes
StatusFileSize
new 2231693-21.patch742 bytes

The patch for 8 in #12 no longer applies. Here's a reroll.

Bryn Vertesi’s picture

Bryn Vertesi commented
Status: Needs review » Reviewed & tested by the community

Patch applied just fine. Looks like that URL is right.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 8.0.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed c7cce61 and pushed to 8.0.x. Thanks!

  • alexpott committed c7cce61 on 8.0.x 
    Issue #2231693 by amitgoyal, joshi.rohit100, helmo, LinL, iS: [Follow up...
dcam’s picture

dcam commented

Testing the 7.x patch in #12.

dcam queued 12: update_powered_by-2231693-12-D7.patch for re-testing.

dcam’s picture

dcam commented
Status: Patch (to be ported) » Reviewed & tested by the community

I tested the 7.x patch in #12. It changes the link correctly.

secretsayan’s picture

secretsayan commented

RTBC + 1

The last submitted patch, 12: update_powered_by-2231693-12-D7.patch, failed testing.

David_Rothstein’s picture

David_Rothstein commented
Title: [Follow up] Update Powered by Drupal link » Update Powered by Drupal link
Status: Reviewed & tested by the community » Fixed

Committed to 7.x - thanks!

  • David_Rothstein committed a0561f8 on 7.x 
    Issue #2231693 by helmo, amitgoyal, joshi.rohit100, LinL, iS: Update...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.