Updated: Comment #0

Problem/Motivation

\Drupal::entityQueryAggregate() typehints \Drupal\Core\Entity\Query\QueryInterface, but returns \Drupal\Core\Entity\Query\QueryAggregateInterface.

Proposed resolution

Typehint \Drupal\Core\Entity\Query\QueryAggregateInterface in \Drupal::entityQueryAggregate()

See line 382 of core/lib/Drupal.php.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#2 core-entity-query-aggregate-type-hint-2231485-2.patch632 bytesfoxtrotcharlie

Comments

foxtrotcharlie’s picture

foxtrotcharlie commented
Assigned: Unassigned » foxtrotcharlie
foxtrotcharlie’s picture

foxtrotcharlie commented
Status: Active » Needs review
StatusFileSize
new core-entity-query-aggregate-type-hint-2231485-2.patch632 bytes
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Good catch!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Nice!

Committed and pushed to 8.x. Thanks!

  • Commit 3d856f3 on 8.x by webchick: 
    Issue #2231485 by foxtrotcharlie | tstoeckler: Wrong type-hint for \...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.