The progress bar should also be applicable for other entities and should therefore reside in salsa_entity and not in salsa_donate_page. As a first step add the progress bar to the single target action form of salsa_advocacy.
Move the theme function out into salsa_entity. To apply the progress bar in salsa_advocacy (at least for single target actions) we need a function the counts existing actions that were taken to display the progress. Additionally there has to be a configuration for the goal field similar to the one we have now for donate pages.
| Comment | File | Size | Author |
|---|---|---|---|
| #21 | generic_progress_bar-2231469-21.patch | 30.14 KB | s_leu |
| #20 | generic_progress_bar-2231469-20.patch | 25.28 KB | s_leu |
| #19 | generic_progress_bar-2231469-19.interdiff.txt | 3.92 KB | s_leu |
| #19 | generic_progress_bar-2231469-19.patch | 29.35 KB | s_leu |
| #17 | generic_progress_bar-2231469-17.patch | 29.42 KB | s_leu |
Comments
Comment #1
s_leu commentedAdding a first patch that moves the theme function as well as the CSS and also changes all relevant parts in code. It will also allow to configure the progress bar for single target actions.
Comment #2
s_leu commentedComment #3
s_leu commentedSmall improvement on the settings form: Moved the fieldset definition to the inside of the condition.
Comment #4
s_leu commentedComment #5
s_leu commentedMade some further improvements and fixed some stuff that i missed in the last patch.
Comment #6
s_leu commentedComment #7
s_leu commentedAdded the progress bar to the petition form as well now. Also did some refactoring which makes it even easier to add the progress bar to further other entities.
Comment #8
s_leu commentedFixed typo in fieldname on salsa_advocacy system settings form.
Comment #9
s_leu commentedMoved the correction of the progress bar element's weight into the condition on the petition progress bar.
Comment #10
s_leu commentedSomehow i lost some stuff of the original patches over time. So here is the complete patch with some improvements.
Comment #11
s_leu commentedFixed few things that were obsolete such as the salsa entity object in the progress bar add function. Also changed the barometer type parameter to form_state as for the new introduced progress bar animation js requires id's in js settings and theme function output.
Also implemented hook_library for the progress bar js and css. In salsa donate page i fixed the labels alter hook to add a condition in the hook (it was altering labels for all forms before that change).
Comment #12
s_leu commentedAdded option to disable progress bar globally and function in JS, that ensures that numbers can be parsed from strange strings like $12,000.00 USD, which failed before and led to broken progress bars.
Comment #13
s_leu commentedImproved JS loading that counts up in numbers instead of percent.
Comment #14
s_leu commentedSome further improvements including parallel animations if multiple progress bars are displayed on the same page. Also some setting in the UI that enables configuration of the animation speed.
Comment #15
s_leu commentedAdded a configuration option in the UI that enables to switch between percent and absolute display when counting up the progress.
Comment #17
s_leu commentedAlso turned the static label into percent display if the entity is configured with percent display and rerolled against latest 7.x-1.x.
Comment #18
s_leu commentedComment #19
s_leu commentedFixed a bug in JS: Function was declared inside an if statement. This would break the JS in certain browsers.
Comment #20
s_leu commentedRe-rolled the patch and changed the counter function in salsa_avocacy to use EFQ instead of the salsa API in order to introduce a tag that allows altering the query.
Comment #21
s_leu commentedSomehow the JS and CSS files were missing again in the latest patch, re-added it.
Comment #23
berdirThanks, finally committed this.