Certain server configurations will not return TRUE for HTTPS, even though server may be serving pages securely. One example of this is when a load balancer handles all secure file serving, but the servers behind the load balancer do not serve secure pages.

I'm suggesting a 'HTTPS' variable setting in lieu of relying on $_SERVER. Patch coming soon....

CommentFileSizeAuthor
#13 storage_api-https-2231027-13.patch579 bytesJMTorres
#11 storage_api-https-2231027-11.patch519 bytesJMTorres
#4 storage_api-https-2231027-4-D7.patch438 bytesstimalsina
#2 storage_api-https-2231027-3.patch578 bytesclevername

Comments

Andre-B’s picture

Andre-B
Primary language German
Location Offenburg, Germany
commented
Status: Needs review » Closed (won't fix)

no patch, won't fix. please come back with a solution and/ or references to other modules handling this issue.

clevername’s picture

clevername commented
Status: Closed (won't fix) » Needs review
StatusFileSize
new storage_api-https-2231027-3.patch578 bytes

The attached patch adds a check for $_SERVER['HTTP_X_FORWARDED_PROTO'] as a workaround. Also see #313145: Support X-Forwarded-* HTTP headers alternates for the larger issue with Drupal core.

cesarmiquel’s picture

cesarmiquel commented

We are having issues here when this functions get called via cron as the $_SERVER variable is not defined. How should this code be changed?

stimalsina’s picture

stimalsina commented
StatusFileSize
new storage_api-https-2231027-4-D7.patch438 bytes

Here's my take on it. The patch in #2 is mostly okay, but we only need check if the `HTTPS` is set.

Status: Needs review » Needs work

The last submitted patch, 4: storage_api-https-2231027-4-D7.patch, failed testing.

perignon’s picture

perignon commented

This patch fails to apply.... Maybe it wasn't rolled against dev.

  • Perignon committed 945b42b on 7.x-1.x 
    Issue #2231027 by clevername, stimalsina, Perignon: https setting not...
perignon’s picture

perignon commented

I manually updated the code and pushed it to dev.

perignon’s picture

perignon commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 4: storage_api-https-2231027-4-D7.patch, failed testing.

JMTorres’s picture

JMTorres commented
Version: 7.x-1.5 » 7.x-1.x-dev
Priority: Normal » Critical
StatusFileSize
new storage_api-https-2231027-11.patch519 bytes

The last commit broke the module with an errant typo. Rerolled this against the latest dev and modified the function to call drupal_is_https() before checking proxy headers.

JMTorres’s picture

JMTorres commented
Status: Needs work » Needs review
JMTorres’s picture

JMTorres commented
StatusFileSize
new storage_api-https-2231027-13.patch579 bytes

Uploaded wrong patch, here is the correct one.

  • Perignon committed 3d0e0fa on 7.x-1.x authored by JMTorres 
    Issue #2231027 by JMTorres, clevername, stimalsina, Perignon: https...
perignon’s picture

perignon commented

Committed to dev.

The last submitted patch, 11: storage_api-https-2231027-11.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 13: storage_api-https-2231027-13.patch, failed testing. View results

perignon’s picture

perignon commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 13: storage_api-https-2231027-13.patch, failed testing. View results

perignon’s picture

perignon commented
Status: Needs work » Fixed

Tests passed on TravisCI https://travis-ci.org/taz77/drupal_storage_api

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.