The highest port number is 65535 instead of 65536.

http://stackoverflow.com/questions/113224/what-is-the-largest-tcp-ip-net...

The validation is wrong in the \Core\Database\Install\Tasks::getFormOptions()
$form['advanced_options']['port'] = array(...);

CommentFileSizeAuthor
#1 drupal-maximum-port-number-2228801-01-d8.patch531 bytessweetchuck

Comments

sweetchuck’s picture

sweetchuck
Primary language Hungarian
Location Budapest
commented
Status: Needs work » Needs review
StatusFileSize
new drupal-maximum-port-number-2228801-01-d8.patch531 bytes
danblack’s picture

danblack commented

nice and simple. For a newbie, why doesn't this have validateDatabaseSettings validating the port number like #1938224?

sweetchuck’s picture

sweetchuck
Primary language Hungarian
Location Budapest
commented

@danblack #2 We do not need validate manually the port number because the new #type = 'number' form element type do the job thanks to #min and #max properties.

danblack’s picture

danblack commented
Status: Needs review » Reviewed & tested by the community

good! :-)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Oops, nice catch. :)

Committed and pushed to 8.x. Thanks!

  • Commit b7364e7 on 8.x by webchick: 
    Issue #2228801 by Sweetchuck: Fix maximum port number.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.