Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
views.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
27 Mar 2014 at 00:21 UTC
Updated:
29 Jul 2014 at 23:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
mandar.harkare commentedI am really not sure why patch by mortendk failed.
Comment #4
mandar.harkare commentedNew line was missing.
Comment #6
pakmanlhHere I attach the rerolled patch modifying the test which failed, changing the div removed selector by only the anchor tag.
Comment #7
star-szrWhat about this:
All on one line and not indented.
Comment #8
galooph commentedComment #9
galooph commentedThe changes to the tests in the patch from #6 look sound to me. I've run the Drupal\views\Tests\Plugin\DisplayTest->testReadMore() test locally and it passes ok.
Comment #10
galooph commentedHere's the patch from #6 but with the link all on one line and not indented, as per #7.
Comment #12
pakmanlhHere the patch again.
Comment #13
star-szrLooks great to me.
Comment #14
tim.plunkettIn HEAD this is display: block, because its a div. With this, its now displayed inline, which is a regression.
I'd say won't fix this, but if not, then put display:block in system.theme.css
Comment #15
mortendk commenteddisplay: block added to .more-link
do we need screenshots as well ?
Comment #16
star-szrScreenshots yes please. And we have .more-link for non-Views more links so those need to be checked as well.
Thanks @tim.plunkett for catching this!
Comment #17
mortendk commentedand heres the screenshots
Comment #18
mortendk commentedHeres the screenshots:
BArtik
before

after

Block before


Block after
seven
before


after
Stark
before


after
Comment #19
tim.plunkettLooks great, thanks for the fix and screenshots!
Comment #20
manuel garcia commentedComment #21
manuel garcia commentedComment #22
webchickAwesome, thanks. :)
Committed and pushed to 8.x.