Updated: Comment #N
We have this like in ViewsPluginManager:
$this->setCacheBackend($cache_backend, $language_manager, "views:{$type}_plugins");
We don't really need that. Plus ViewsHandlerManager just has the prefix of "views$handler_type".
Remove it!
| Issue category | Task, because it "just" improves consistency |
|---|---|
| Issue priority | Minor, because the effect is really small |
| Disruption | Not disruptive at all, people with sites will just fetch from the different named cache entry, fail, and rebuild it, done. |
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 2226629-7.patch | 645 bytes | rpayanm |
| #1 | 2226629.patch | 657 bytes | damiankloip |
Comments
Comment #1
damiankloip commentedComment #2
damiankloip commentedComment #3
damiankloip commentedComment #4
dawehnerMh I kinda like these prefixes so it is quite clear what this cache entry is about, if you ever would look it up in the db for example.
Comment #5
damiankloip commentedok, then we should go the other way, and be explicit all the time?
Comment #6
jhedstromReclassifying--not strictly a bug.
Comment #7
rpayanmComment #8
rpayanmComment #9
damiankloip commentedDo we want this? I am for, dawehner is against :)
Comment #10
dawehnerDamian knows much more about caching than I do, so let's be fair here.
Comment #13
jhedstromBack to RTBC.
Comment #22
jhedstromAnd again.
Comment #23
alexpottThis issue is a minor task so we need to outline how it fits within the allowable Drupal 8 beta criteria. Can someone add Drupal 8 beta phase evaluation template to the issue summary.
This patch has zero disruption and increases consistency between ViewsHandlerManager and ViewsPluginManager.
Comment #24
dawehnerSure
Comment #25
alexpottThanks @dawehner.
Committed f98c96a and pushed to 8.0.x. Thanks!