Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
ResponsiveImageMappingEntityTest is assigned to incorrect groups.
In the docblock, groups Drupal and Config are defined.
In getInfo(), Picture is defined.
The getInfo group should be changed to Responsive Image to match ResponsiveImageAdminUITest and ResponsiveImageFieldDisplayTest (as per #2124377: Rename "Picture" module to "Responsive Image" module).
For consistency, the docblock groups should therefore be Drupal and Responsive_image.
Comment | File | Size | Author |
---|---|---|---|
#6 | fix_naming_in-2225677-5.patch | 9.37 KB | Eli-T |
#2 | 2225677-ResponsiveImageMappingEntityTest-naming.patch | 9.37 KB | mcjim |
Comments
Comment #1
Eli-TWe should also pull out all other references to Picture module in the unit tests out in this issue.
$picture_mapping = new ResponsiveImageMapping(array(), $this->entityTypeId);
Comment #2
mcjim CreditAttribution: mcjim commentedPatch does the following:
Comment #3
Eli-TLooks good and tests pass, but probably needs someone other than me to RTBC given I've already input in to the solution.
Note this will need reroll if #2030653: Expand ResponsiveImageMapping with methods is committed before it.
Comment #4
Eli-TNeeds slight reroll now #2030653: Expand ResponsiveImageMapping with methods *has* been committed.
Comment #5
Eli-TComment #6
Eli-TReroll following #2225677: Fix naming in ResponsiveImageMappingEntityTest following module rename from Picture to Responsive Image
Comment #8
Eli-T6: fix_naming_in-2225677-5.patch queued for re-testing.
Comment #9
Eli-TRe-queued as all tests pass locally.
Comment #10
marcvangendCode looks good, tests still pass locally, and all references to "picture" are gone. RTBC as far as I can tell.
Comment #11
alexpottCommitted 86a9e55 and pushed to 8.x. Thanks!