Problem/Motivation

The delete tab for aggregator feeds does not appear because of wrong yaml key (tab_root_id instead of base_route)

Proposed resolution

Fix, add a test

Remaining tasks

Commit

User interface changes

The Delete tab now actually appears

API changes

None

Original report by @ParisLiakos

Yes, i missed #2107531: Improve DX of local task YAML definitions, but thats ok because now i have to add a test :P

CommentFileSizeAuthor
#5 drupal-aggregator_local_tasks-2224951-5.patch1.27 KBsumeetjaggi
#3 drupal-aggregator_local_tasks-2224951-3.patch1.15 KBParisLiakos
#1 drupal-aggregator_local_tasks-2224951.patch1.23 KBParisLiakos

Comments

ParisLiakos’s picture

ParisLiakos commented
Status: Active » Needs review
StatusFileSize
new drupal-aggregator_local_tasks-2224951.patch1.23 KB
ParisLiakos’s picture

ParisLiakos commented
Issue summary: View changes
ParisLiakos’s picture

ParisLiakos commented
StatusFileSize
new drupal-aggregator_local_tasks-2224951-3.patch1.15 KB

reroll

Jalandhar’s picture

Jalandhar commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

Patch #3, needs to be updated.

sumeetjaggi’s picture

sumeetjaggi commented
Status: Needs work » Needs review
Issue tags: +#SprintWeekend2015
StatusFileSize
new drupal-aggregator_local_tasks-2224951-5.patch1.27 KB

Patch rerolled!

sumeetjaggi’s picture

sumeetjaggi commented
Issue tags: -#SprintWeekend2015 +SprintWeekend2015
manningpete’s picture

manningpete commented
Issue tags: -Needs reroll

Patch applies.

ParisLiakos’s picture

ParisLiakos commented
Status: Needs review » Reviewed & tested by the community

thanks for the reroll

ParisLiakos’s picture

ParisLiakos commented
Issue summary: View changes
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 5297f9e and pushed to 8.0.x. Thanks!

  • alexpott committed 5297f9e on 8.0.x 
    Issue #2224951 by ParisLiakos, Sumeet Jaggi: Aggregator delete local...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.