Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Updated: Comment #N
Problem/Motivation
Proposed resolution
Instead of injecting request
service, rather use the Symfony 2.4 request_stack
in LocalActionManager
and LocalTaskManager
.
Remaining tasks
User interface changes
API changes
Comment | File | Size | Author |
---|---|---|---|
#13 | 2223615-use-request-stack-in-local-task-action-13.diff | 15.51 KB | znerol |
#7 | 2223615-use-request-stack-in-local-task-action-7.diff | 15.5 KB | znerol |
#4 | 2223615-use-request-stack-in-local-task-action-4.diff | 15.49 KB | znerol |
#3 | interdiff.txt | 1.31 KB | znerol |
#3 | 2223615-use-request-stack-in-local-task-action-2.diff | 15.47 KB | znerol |
Comments
Comment #1
znerol CreditAttribution: znerol commentedComment #3
znerol CreditAttribution: znerol commentedAlso fix
LocalTaskIntegrationTest
.Comment #4
znerol CreditAttribution: znerol commentedReroll, no changes.
Comment #5
dawehnerPerfect!
Comment #7
znerol CreditAttribution: znerol commentedReroll after #2221065: Rename default 'cache' cache bin to 'default'.
Comment #8
dawehnerre-rtbc
Comment #10
znerol CreditAttribution: znerol commented7: 2223615-use-request-stack-in-local-task-action-7.diff queued for re-testing.
Comment #11
dawehnerre-rtbc
Comment #13
znerol CreditAttribution: znerol commentedReroll after #2228291: Move all plugin and other discovery data into a cache_discovery bin
Comment #14
dawehnerStill fine.
Comment #15
alexpottCommitted bd468f2 and pushed to 8.x. Thanks!
Comment #16
alexpottLooks like the https://drupal.org/node/2026025 could do with an update
Comment #18
znerol CreditAttribution: znerol commented@alexpot: see #2236207: Use router request context instead of request service in system breadcrumb builder and also the other child issues of #2223189: Use regular upstream HttpKernel instead of Drupal's custom.
Comment #20
YesCT CreditAttribution: YesCT commentedthis issue took out where $request was used, but didn't take out where it was set.
core/tests/Drupal/Tests/Core/Menu/LocalTaskIntegrationTest.php
$request = $this->getMock('Symfony\Component\HttpFoundation\Request');
I suppose taking out the now unused var in #2081153: Remove unused local variables from core/tests is fine.
adding that as a related issue to this.