Updated: Comment #N

Problem/Motivation

Entity is abstract right now, but happens to implement every method on the interface.
Additionally, we have several test entity classes that extend Entity directly.
Anytime we try to add a new method to EntityInterface that has no generic implementation, we're forced to either duplicate code in those subclasses, or put an empty implementation in Entity

Proposed resolution

Use getMockForAbstractClass() instead of fakes in phpunit tests

Remaining tasks

M/

User interface changes

API changes

CommentFileSizeAuthor
#5 drupal_2223423_5.patch10.22 KBxano
#1 entity-2223423-1.patch12.49 KBtim.plunkett

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
StatusFileSize
new entity-2223423-1.patch12.49 KB

Also removed the leftover FieldUITestNoBundle.

Status: Needs review » Needs work

The last submitted patch, 1: entity-2223423-1.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Needs review

1: entity-2223423-1.patch queued for re-testing.

ParisLiakos’s picture

ParisLiakos commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

+1

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review
StatusFileSize
new drupal_2223423_5.patch10.22 KB

Re-roll.

Status: Needs review » Needs work

The last submitted patch, 5: drupal_2223423_5.patch, failed testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review

5: drupal_2223423_5.patch queued for re-testing.

ParisLiakos’s picture

ParisLiakos commented
Status: Needs review » Reviewed & tested by the community

thanks

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed a167eca and pushed to 8.x. Thanks!

  • Commit a167eca on 8.x by alexpott: 
    Issue #2223423 by Xano, tim.plunkett: Stop extending \Drupal\Core\Entity...
star-szr’s picture

star-szr
he/him
Primary language English
commented
Issue tags: -Needs reroll

Don't mind me…

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.