Problem/Motivation

The documentation of ImageInterface::getTookit lists the wrong return type.

  /**
   * Returns the image toolkit used for this image file.
   *
   * @return string
   *   The image toolkit.
   */
  public function getToolkit();

With this, IDE's can't make proper suggestions for the returned value.

Proposed resolution

Change string to \Drupal\Core\ImageToolkit\ImageToolkitInterface.

Remaining tasks

none

API changes

none

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Sutharsan’s picture

Status: Active » Needs review
FileSize
0 bytes
Sutharsan’s picture

FileSize
511 bytes

now with a correct patch.

mondrake’s picture

Status: Needs review » Reviewed & tested by the community

Good catch, thanks!

webchick’s picture

Component: image system » documentation
Status: Reviewed & tested by the community » Fixed

Nice one.

Committed and pushed to 8.x. Thanks!

  • Commit b7de429 on 8.x by webchick:
    Issue #2222911 by Sutharsan: Wrong return type in ImageInterface::...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.