#2151459: Enable node render caching introduced a new test in Drupal\system\Tests\Common\RenderTest but did not use randomContextValue which was added a few days before in #2197359: Random failure in Drupal\system\Tests\Common\RenderTest. Therefore the new test is subject to the same failure mode prevented in #2197359: Random failure in Drupal\system\Tests\Common\RenderTest.

---- Drupal\system\Tests\Common\RenderTest ----


Status    Group      Filename          Line Function
--------------------------------------------------------------------------------
Fail      Other      RenderTest.php     914 Drupal\system\Tests\Common\RenderTe
    The token attribute was found in the cached child element markup
Fail      Other      RenderTest.php     919 Drupal\system\Tests\Common\RenderTe
    The tokens are identical for the child element
Fail      Other      RenderTest.php     939 Drupal\system\Tests\Common\RenderTe
    The token attribute was found in the cached parent element markup
Fail      Other      RenderTest.php     944 Drupal\system\Tests\Common\RenderTe
    The tokens are identical for the parent element
Fail      Other      RenderTest.php     968 Drupal\system\Tests\Common\RenderTe
    The token attribute was found in the cached child element markup
Fail      Other      RenderTest.php     973 Drupal\system\Tests\Common\RenderTe
    The tokens are identical for the child element

Comments

alexpott’s picture

Status: Active » Needs review
StatusFileSize
new1.28 KB
new645 bytes
new662 bytes

With the applied patch I cannot reproduce the fail even after running the test 400 times.

wim leers’s picture

Status: Needs review » Reviewed & tested by the community

Looks sane.

The last submitted patch, 1: 2222315.test-only.will-fail.patch, failed testing.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Hm. This proliferation of randomFoo functions is starting to get a bit crazy. It's little wonder we keep introducing random fails. :(

Anyway, great catch, committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

sun’s picture

Issue tags: -Random fail +Random test failure