Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
base system
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
19 Mar 2014 at 23:15 UTC
Updated:
29 Jul 2014 at 23:27 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
grom358 commentedUsing Function Replacer Part of Write script to automate replacement of deprecated functions where possible.
Comment #2
grom358 commentedComment #3
grom358 commentedI think this issue is duplicate of https://drupal.org/comment/8592499#comment-8592499
Comment #4
ianthomas_ukI've marked that as a duplicate of this, and I'm stealing its Core Review Bonus tag.
Comment #5
ianthomas_ukI've not reviewed the patch itself, but those function_replace commands look correct
Comment #6
ianthomas_ukNeeds reroll. I tried, using the commands above, but got
Comment #7
grom358 commentedIan what version of PHP you on?
Comment #8
ianthomas_ukA few comments needed to be wrapped to 80 chars, but otherwise that's fine. No references to these functions remain, even in comments.
This fixes the wrapping, hopefully it's still OK for me to mark as RTBC.
Comment #9
ianthomas_ukSetting to needs work, as this is not suitable for commit during Szeged and it's a pretty safe bet that it will conflict with something before the end of the week.
I have spoken to webchick and she suggested that she would be available to review/commit this next Monday, 31st March. There's little point in rerolling the patch until the weekend, but if there's a patch here on Monday that applies then I'll review it.
Comment #10
grom358 commentedComment #11
grom358 commentedRerolled
Comment #12
ianthomas_ukThat's a good reroll. The main changes were done correctly and due to
https://github.com/drupal/drupal/commit/dc15bf2eb231238b601d692da5f59d1b...
https://github.com/drupal/drupal/commit/bead76ad5b8c9e23caf2e5efea2bee01...
https://github.com/drupal/drupal/commit/13242b5af695a0f2aa386ded894a5bc0...
The other changes are just context, except:
It looks like the script is wrapping comments at 79 characters rather than 80, but the docblock is still easily readable so I'm not going to set needs work for that.
Comment #13
webchickCommitted and pushed to 8.x. Thanks! Changes are covered in https://drupal.org/node/2173683.