Color palette setting controls are duplicated

So this is strange. The issue is that there are infact too select dropdowns, the second one sticks and the former actually seems to be related to locking colours. So I think this is more a case where we need documentation to explain what the first field set is for vs the second.

Can you try attached patch to see what causes the form to get invoked twice?

The function in question is only called once. The 2 form elements are not the same.

The top item is built by $form['scheme']

js' => array(
        array(
          'data' => array(
            'color' => array(
              'reference' => color_get_palette($theme, TRUE),
              'schemes' => $schemes,
            ),
            'gradients' => $info['gradients'],
          ),
          'type' => 'setting',
        ),
      ),

The lower is

// Add palette fields.
  $palette = color_get_palette($theme);

So one is provide settings for a schema, while the other is too set the actual values for the theme. Yes it is totally confusing but I think the real issue is one needs better help text for the end user.

Mistake in the template?

<div class="color-form clearfix">
  {{ form.scheme }}
  <div id="palette" class="clearfix">
    {{ form.palette }}
  </div>

  {{ form }} <---------------------   whats this doing here?

  <h2>{{ 'Preview'|t }}</h2>
  {{ html_preview }}
</div>

I opened #2257321: Color form is duplicated without searching - bad me. This is a major bug - we could not release with it.

Same patch from that issue.

Attaching related issues which caused this regression. I'm tempted to say that this |without filter changed how the render arrays work. This patch shouldn't be necessary because the palette is already printed prior to the rest of the form.

edit: after chatting with @alexpott in IRC, I was unaware that this is, in fact, the desired behavior and fundamental change with how render arrays work. The patch is correct.

Well plenty of templates already work this way - consider node.html.twig or node-edit-form.html.twig

Looks good, I learned something new about twigg which is also good!

7: 2221041.7.patch queued for re-testing.

RTBC from me.

Before:

After:

Tests also pass locally (was unsure with the testbot random failures):

Test only patch:

84.73 KB - /sandbox/sites/d8.sandbox (*2221041)
markcarver@Marks-MacBook-Air$ sudo -u _www php ./core/scripts/run-tests.sh --url http://d8.sandbox --class "Drupal\color\Tests\ColorTest"
Password:

Drupal test run
---------------

Tests to be run:
  - Drupal\color\Tests\ColorTest

Test run started:
  Saturday, May 3, 2014 - 15:46

Test summary
------------

Drupal\color\Tests\ColorTest                                 118 passes   2 fails

Test run duration: 26 sec

Full patch:

84.73 KB - /sandbox/sites/d8.sandbox (*2221041)
markcarver@Marks-MacBook-Air$ sudo -u _www php ./core/scripts/run-tests.sh --url http://d8.sandbox --class "Drupal\color\Tests\ColorTest"

Drupal test run
---------------

Tests to be run:
  - Drupal\color\Tests\ColorTest

Test run started:
  Saturday, May 3, 2014 - 15:38

Test summary
------------

Drupal\color\Tests\ColorTest                                 120 passes

Test run duration: 30 sec

Very nice catch.

Committed and pushed to 8.x. Thanks!