Closed (fixed)
Project:
Google Search Appliance
Version:
7.x-1.13
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
17 Mar 2014 at 14:54 UTC
Updated:
28 Oct 2015 at 21:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
jamsilver commentedPatch attached.
Comment #2
jamsilver commentedAdded features:
Comment #3
jamsilver commentedComment #4
iamEAP commentedThanks @jamsilver. This is definitely a common requirement that I'd like to support. I haven't found any issues in reviewing the patch; I'll test in simplytest.me and on our existing installation before committing.
Thanks for your contribution!
Comment #5
iamEAP commentedOne thing that did come up in testing is that if you have both Core search and GSA enabled (and responding at /search), people will no longer be able to search for "node" or "user" because /search/node and /search/user correspond to core search callbacks.
I think that's a use-case we can call "unsupported," as long as we note it in the documentation / README.txt. While we're in there, we should update the README to reflect this new feature.
Comment #6
iaminawe commentedI found this worked great if my path was just /search or just /internal but broken when I set it to /search/internal which is what I needed.
I submit a small addition to the above patch that will work for if you need to have two levels above the actual keyword being searched in the url.
Comment #7
iamEAP commentedThat actually brings up a very good point. Rather than hardcoding it, as suggest by @iaminawe in #6...
We should adjust the page arguments based on the depth provided by the "drupal_path" variable. Should be pretty straightforward.
This is in addition to adding/adjusting details in the README.txt (#5).
Comment #8
iaminawe commentedYes that makes more sense than hardcoding it iamEAP. Thanks
Comment #9
iamEAP commentedHere's a re-roll of #3 against the latest codebase. Still need to add/update documentation and account for the page arguments (#7).
Comment #10
iamEAP commentedAaand here's #9 with the dynamic menu arguments and documentation changes. Interdiff for the highlights.
@iaminawe or @jamsilver, would you mind testing and reviewing?
Comment #11
juliakoelsch commentedWe have applied this patch successfully, and it works great. Thank you!
Comment #12
timwoodRerolled patch file for version 7.x-1.13. Should probably be done for -dev, but this is what I was able to do for now.
Comment #14
iamEAP commentedThanks all! Looks good and committed to 7.x-1.x-dev.