SystemControllerTest::setLinkActiveClass() unit test has wrong namespace and lives in wrong location [#2219457]

#1979468: ".active" from linkGenerator(), l() and theme_links() forces an upper limit of per-page caching for all content containing links introduced \Drupal\system\Controller\SystemController::setLinkActiveClass(), plus accompanying test coverage. Now it turns out that it both has the wrong namespace (my fault: copy/pasting from Edit module tests) and lives in the wrong location (Views module instead of System module — nod_'s last reroll accidentally moved it).

This is a simple fix for precisely that. It only moves the file and corrects the namespace.

Comment	File	Size	Author
	systemcontrollertest_fix.patch	1.03 KB	wim leers

Comments

Comment #1

berdir

German

Switzerland

commented 17 March 2014 at 13:38

Status:

Needs review

» Reviewed & tested by the community

Thanks!

Note that the test was actually executed, that's how we noticed it in the output (it has 2.8k assertions, which means that it's a character off in the new run-tests.sh output). PhpUnit somehow found the class, only the gods know why ;)

Comment #2

wim leers

Ghent 🇧🇪🇪🇺

commented 17 March 2014 at 13:40

#1: I was wondering about that too… Very bizarre. But that's also why we didn't notice it before: because we saw that the tests *were* being executed.