CommentFileSizeAuthor
#1 2219055-rules-block-ip-action.patch3.76 KBdave reid

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
StatusFileSize
new 2219055-rules-block-ip-action.patch3.76 KB
geerlingguy’s picture

geerlingguy commented
Status: Needs review » Reviewed & tested by the community

Seems to work for me. I'm interested in seeing this added so #2218537: Add Trigger and Rules event support can add oft-requested functionality for spam bot banning for Honeypot users. I tested the banning of the current user's IP address (as determined by ip_address()), but didn't test adding code to use some other IP address...

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Reviewed & tested by the community » Fixed

Thanks, patch looks good and makes nicely use of the API for adding data types. Committed to 7.x-2.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Jeroen94’s picture

Jeroen94 commented

The 'Block IP address' action only supports values of the type 'IP address', which is a good thing. However, the built-in hostname of e.g. comments is not of this type. Therefore, tokens like [comment:hostname] are not accepted by the action. Apparently, it is also not possible to convert into an IP address type. Is this desirable?