This issue has novice tasks. If you are an experienced core developer and have multiple commit mentions, please review novices' work on these tasks rather than doing them yourself. Feedback from experienced contributors is valued.
Problem/Motivation
The following line from twig.engine is no longer needed now that TwigReference is gone via #2114563: Remove TwigReference with the help of 'without' filter replacing 'show'/'hide' functions.. When dumping all available variables in a Twig template _references shows up.
$variables['_references'] = array();
Proposed resolution
Remove the line.
Remaining tasks
- Write patch (novice)
- Review patch to check it fixes the issue, the change is properly documented and for coding standards.
User interface changes
n/a
API changes
n/a
Comment | File | Size | Author |
---|---|---|---|
#2 | removed_template_references_line_from_twir_render_template-2218849-2.patch | 520 bytes | Anonymous (not verified) |
Comments
Comment #1
star-szrAdding the code in question to the issue summary.
Comment #2
Anonymous (not verified) CreditAttribution: Anonymous commentedI removed the $variables['_references'] = array(); line from the code
Comment #3
martin107 CreditAttribution: martin107 commented@hellboy2k8 ... Changing the status of the issue to "Needs review" triggers a testbot into looking at the issue.. hope this helps.
Comment #4
star-szrThat was quick :D thanks @hellboy2k8 (and @martin107 for the assist)!
RTBC once testbot comes back green.
Comment #5
Anonymous (not verified) CreditAttribution: Anonymous commented@martin107 thanks for the help :-) I will remember this
Comment #7
joelpittetfluke test fails
Comment #8
joelpittet2: removed_template_references_line_from_twir_render_template-2218849-2.patch queued for re-testing.
Comment #9
webchickNice catch!
Committed and pushed to 8.x. Thanks!