This issue has novice tasks. If you are an experienced core developer and have multiple commit mentions, please review novices' work on these tasks rather than doing them yourself. Feedback from experienced contributors is valued.

Problem/Motivation

The following line from twig.engine is no longer needed now that TwigReference is gone via #2114563: Remove TwigReference with the help of 'without' filter replacing 'show'/'hide' functions.. When dumping all available variables in a Twig template _references shows up.

  $variables['_references'] = array();

Proposed resolution

Remove the line.

Remaining tasks

User interface changes

n/a

API changes

n/a

Files: 
CommentFileSizeAuthor
#2 removed_template_references_line_from_twir_render_template-2218849-2.patch520 byteshellboy2k8
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 66,472 pass(es). View

Comments

Cottser’s picture

Issue summary: View changes

Adding the code in question to the issue summary.

hellboy2k8’s picture

FileSize
520 bytes
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 66,472 pass(es). View

I removed the $variables['_references'] = array(); line from the code

martin107’s picture

Status: Active » Needs review

@hellboy2k8 ... Changing the status of the issue to "Needs review" triggers a testbot into looking at the issue.. hope this helps.

Cottser’s picture

Status: Needs review » Reviewed & tested by the community

That was quick :D thanks @hellboy2k8 (and @martin107 for the assist)!

RTBC once testbot comes back green.

hellboy2k8’s picture

@martin107 thanks for the help :-) I will remember this

Status: Reviewed & tested by the community » Needs work
joelpittet’s picture

Status: Needs work » Reviewed & tested by the community

fluke test fails

joelpittet’s picture

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Nice catch!

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.