ConfigImporter assumes that a ConfigEntity uses a storage controller that implements ConfigStorageControllerInterface

I think there's a related issue about config entities being tied to config storage controller...

Tagging

@tim.plunkett I didn't disagree with the direction :) and I certainly did not mean to delete it :)

+++ b/core/lib/Drupal/Core/Config/ConfigImporter.php
@@ -315,7 +316,8 @@ protected function importInvokeOwner($op, $name) {
+      $handled_by_module = $entity_storage instanceof ConfigStorageControllerInterface ? $entity_storage->$method($name, $new_config, $old_config) : FALSE;

Doing this means that the config object will be updated by the config system instead :( see ConfigImporter::process(). Thinking about it the ConfigImporter::process() code looks extremely dodgy. I don't think if the configuration entity system does not implement the ConfigStorageControllerInterface then we should just jam the changes in using the simple config system.

  protected function process($op, $name) {
    if (!$this->importInvokeOwner($op, $name)) {
      $this->importConfig($op, $name);
    }
  }

EDIT: for clarity of dodgyness

Those methods look really misplaced on the ConfigStorageControllerInterface — I don't see how invoking import callbacks/hooks is related to a storage controller at all?

To my knowledge, ConfigImporter was only introduced later on.

Why don't we simply move them entirely into ConfigImporter? At least that sounds like a much more appropriate place?

1. +++ b/core/lib/Drupal/Core/Config/ConfigImporter.php
   @@ -315,9 +319,13 @@ protected function importInvokeOwner($op, $name) {
   +        throw new EntityStorageException('The entity storage does not support imports');
   

   It would be great to explain which entity storage / which entity type does not support imports.

2. +++ b/core/lib/Drupal/Core/Config/Entity/ImportableEntityStorageInterface.php
   @@ -0,0 +1,56 @@
   + * Contains \Drupal\Core\Config\Entity\ImportableEntityStorageInterface.
   

   For a short short moment I thought that this interface could be also usable for something like menu items, served from some static yml file, though yeah nevermind.

1. +++ b/core/lib/Drupal/Core/Config/ConfigImporter.php
   @@ -315,9 +319,13 @@ protected function importInvokeOwner($op, $name) {
   +        throw new EntityStorageException('The entity storage does not support imports');
   

   It would be great to explain which entity storage / which entity type does not support imports.

2. +++ b/core/lib/Drupal/Core/Config/Entity/ImportableEntityStorageInterface.php
   @@ -0,0 +1,56 @@
   + * Contains \Drupal\Core\Config\Entity\ImportableEntityStorageInterface.
   

   For a short short moment I thought that this interface could be also usable for something like menu items, served from some static yml file, though yeah nevermind.

Committed/pushed to 8.x, thanks!