template_preprocess_links uses a non existent class JSON

There is probably just a missing use statement, see https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Component%21Util...

This looks like a big hole in our test coverage?

Not sure how this is novice, except if we also identify which test case need to be extended.

Updated the Test-Case.

Both updated test and fix.

This looks quite fine already!

+++ b/core/modules/system/lib/Drupal/system/Tests/Theme/FunctionsTest.php
@@ -201,6 +209,8 @@ function testLinks() {
+    $expected_links .= '<li class="query-test"><a href="' . url('query/test', array('query' => $query)) . '">' . check_plain('Link with query') . '</a></li>';

@@ -237,6 +247,8 @@ function testLinks() {
+    $expected_links .= '<li class="query-test"><a href="' . url('query/test', array('query' => $query)) . '">' . check_plain('Link with query') . '</a></li>';

@@ -250,6 +262,9 @@ function testLinks() {
+    $encoded_query = check_plain(Json::encode($query));
+    $expected_links .= '<li class="query-test" data-drupal-link-query="'.$encoded_query.'" data-drupal-link-system-path="query/test"><a href="' . url('query/test', array('query' => $query)) . '" data-drupal-link-query="'.$encoded_query.'" data-drupal-link-system-path="query/test">' . check_plain('Link with query') . '</a></li>';

Note: We could use \Drupal::urlGenerate()->generate and String::checkPlain instead

Now uses String::checkPlain instead of check_plain.
Also removed 2 unused "Use" Statements.
About the use of \Drupal::urlGenerate()->generate I'm not sure. As the test currently explicitly differenciates between url based and rout based links. Though just for the added json testcase it makes sense. I'll change that.

Changed the json-test part to be route-based and use Drupal::urlGenerate()->generate() instead of url().

If this issue isn't resolved in the next few days, it should be split into two issues.
1) The one-liner that actually fixes the bug that wasn't detected.
2) The more complex code that detects the bug.

Re-rerolled for PSR-4

14: non-existent-class-json-2217755-14.patch queued for re-testing.

Tests pass locally. Testbot is not providing sufficient detail to identify the failure.

Test information was inadequate :-(

1) More information was obtained by enabling better error reporting see
admin/config/development/logging

2) Web browser testing highlighted the need to keep up with recent HEAD changes to the location of Json::encode()

Patch no longer applies.

Rerolled patch.

The rerolled patch shrank by quite a bit, before reroll was 6.75 KB and now 3.36 KB. Can you try again @er.pushpinderrana?

@Cottser, I would definitely try again tomorrow, I am looking into cause of above test failure. I hope would be able to fixed this tomorrow.

Thanks!

One more try with updated patch.

@Cottser, this time Test Bot make it green :). Nice.

Thanks!

Patch does not apply to HEAD, tagging Needs reroll.

error: patch failed: core/includes/theme.inc:8
error: core/includes/theme.inc: patch does not apply

Here are the reroll instructions.

Patch didn't apply because it tried to put a 'use' statement in a place where another 'use' statement has since been added. Rerolled.

Adding sprint tag.

New patch to keep 'use' statements grouped nicely.

We seem to have proper test coverage now. I wonder whether we could somehow in the future use static code analyze to find
those kind of errors directly in the testbot.