Updated: Comment #N

Problem/Motivation

After #1996238: Replace hook_library_info() by *.libraries.yml file, the CSS is added in the wrong order.
Now the Views UI looks like this:

Proposed resolution

Make the Views UI CSS depend on dropbutton CSS, so that it is added in the correct order.

Remaining tasks

N/A

User interface changes

It doesn't look broken!

API changes

N/A

CommentFileSizeAuthor
#2 Screenshot from 2014-03-14 04:02:45.png125.94 KBbarraponto
#1 vdc-2217669-1.patch418 bytestim.plunkett
views-ui-dropbutton.png134.99 KBtim.plunkett

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
StatusFileSize
new vdc-2217669-1.patch418 bytes
barraponto’s picture

barraponto
he / him
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screenshot from 2014-03-14 04:02:45.png125.94 KB

It does fix the issue.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Issue tags: +Quick fix
markhalliwell’s picture

markhalliwell
Primary language English
commented
Title: Dropbuttons in Views UI look broken » [REGRESSION] Views UI broken - dropbuttons not loaded
sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Looks good, yeah.

I'm not sure how this happened though — I can only assume that the line must have gone lost in one of the many merge conflicts. Sorry for that.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Title: [REGRESSION] Views UI broken - dropbuttons not loaded » [REGRESSION] Views UI broken

In HEAD the dropbuttons.css is loaded, just after the views UI CSS (it is added by the pre_render)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.