API page: https://api.drupal.org/api/drupal/includes%21common.inc/group/sanitizati...
Enter a descriptive title (above) relating to Sanitization functions, then describe the problem you have found:
List of Sanitization functions contains 'filter_xss' twice - ie 2 identical, adjacent entries.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | filter_xss_duplicated_in_list-2216945-10.patch | 502 bytes | asrob |
| #6 | filter_xss_duplicated_in_list-2216945-6.patch | 510 bytes | asrob |
| #2 | filter_xss_duplicated_in_list-2216945-drupal7-2.patch | 502 bytes | asrob |
| #2 | filter_xss_duplicated_in_list-2216945-2.patch | 491 bytes | asrob |
Comments
Comment #1
jhodgdonThat's interesting. It's also true in 8.x.
I was going to say it was an API module bug, but the reason it is happening is that in common.inc there is a line saying
and filter_xss occurs in the file before the @} but it also has @ingroup sanitization in its documentation header. So it is basically being added to the Sanitization topic twice.
So we should remove the @ingroup line from filter_xss(). Seems like a good Novice project?
Comment #2
asrobHi!
I tried to fix this issue for Drupal 8 and 7, attached them as well.
Comment #3
asrobComment #5
jhodgdonThanks for the patch!
In general, it's better to just work on one version at a time (so I'd just want to see an 8.x patch for now). See
https://drupal.org/node/1319154#multiple-versions
for an explanation.
So, just looking at the 8.x patch, can you also remove the extra blank line before the @ingroup, which is left over at the end after removing that line? Thanks!
Comment #6
asrobFirst of all, I got it, thank you for the link! :)
I've fixed it. I hope this will be good.
Comment #7
miraj9093 commentedLooks good to me.
Comment #8
jhodgdonPerfect, thanks! I'll get that committed, and likely the same patch will work for D7 and D8.
Comment #9
jhodgdonCommitted to 8.x, thanks!
I guess we do need a different patch for 7.x: didn't apply there with -p2 (many do; some don't).
Comment #10
asrobThank you!
I attached a patch for 7.x, I hope it will be good. :)
Comment #11
miraj9093 commentedLooks Good to me..
Comment #13
David_Rothstein commented10: filter_xss_duplicated_in_list-2216945-10.patch queued for re-testing.
Comment #14
David_Rothstein commented(Assuming that failure was a fluke given that this is a documentation patch...)
Comment #15
jhodgdonWeird, I didn't know the testbot was having random failures on 7.x as well?
Comment #16
jhodgdonThanks again! Committed to 7.x.