Updated: Comment #0

Problem/Motivation

The following functions are just wrappers for methods of SortArray, are already deprecated and are hardly used in core.

element_sort()
element_sort_by_title()
drupal_sort_title()

Proposed resolution

These functions should all be removed.

Remaining tasks

Write patch
Review patch

User interface changes

None

API changes

Three deprecated functions removed

CommentFileSizeAuthor
#1 drupal-2216565-remove-SortArray-wrappers-1.patch5.17 KBianthomas_uk

Comments

ianthomas_uk’s picture

ianthomas_uk
he/him
Primary language English
Location Brighton, UK
commented
StatusFileSize
new drupal-2216565-remove-SortArray-wrappers-1.patch5.17 KB

I have expanded https://drupal.org/node/2181331 to cover these changes (it should already have been done, so there's no need for this to be committed first).

ianthomas_uk’s picture

ianthomas_uk
he/him
Primary language English
Location Brighton, UK
commented
Status: Active » Needs review
ianthomas_uk’s picture

ianthomas_uk
he/him
Primary language English
Location Brighton, UK
commented
Related issues: +#2208607: Write script to automate replacement of deprecated functions where possible
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

Applies with small offset, no instances of "element_sort" or "drupal_sort_title" found afterwards => RTBC

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

  • Commit dc15bf2 on 8.x by webchick: 
    Issue #2216565 by ianthomas_uk: Remove wrappers for SortArray.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.