has resulted in a patch that is too large. This issue it to take the patch in and splits out the parts suggested as:
Way forward? (each step could be a separate issue)
Split the Config class into a couple of base classes so that the functionality can be reused - the attached patch does this and discovered an issue with ThemeSettings not using the same merge method as Config.
- Add new abstract class ConfigBase and abstract subclass StorableConfigBase
- Make Config extend StorableConfigBase
- Make ThemeSettings extend ConfigBase
as initially committedand suggested to be split out as a separate issue.
Complete patch to follow.
User interface changes
ThemeSettings::mergeData() calls should now call the inherted merge() method.
All current instances of this call to be fixed in this issue.
|#15||ConfigBaseRefactor (1).png||30.97 KB||Gábor Hojtsy|
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 65,392 pass(es). View
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 65,327 pass(es). View