Remove unused Drupal\Core\Utility\Title

Given that the HtmlFragment is a value object this seems doable.

The only use of this is in Views - #2067931: Use the new title method on views pages.

That other issue has been closed.

There is still a usage of this left in \Drupal\views\Plugin\views\area\Title, but that second argument that it is passing along does not even exist anymore, so it is broken anyway.

Making active and tagging Novice, remove the file and usage of it in that other class (there is also a left-over use somewhere else).

We then need to verify that title area works as expected and fix it if necessary.

A patch .

Patch looks good to me. As mentioned above, the title area plugin might be broken, but this doesn't make it any worse than it already is. But lets confirm this with @dawehner.

+++ b/core/modules/views/src/Plugin/views/area/Title.php
@@ -54,7 +53,7 @@ public function preRender(array $results) {
-      $this->view->setTitle($this->sanitizeValue($value, 'xss_admin'), UtilityTitle::PASS_THROUGH);
+      $this->view->setTitle($this->sanitizeValue($value, 'xss_admin'));

Ha, ViewExecutable::setTitle does not deal anymore with the variable itself.

Later in Page::execute() we use Xss::filterAdmin() so the title plugin does not seems to be broken.

.

> Ha, ViewExecutable::setTitle does not deal anymore with the variable itself.

Meaning, this is correct since ViewExecutable::setTitle is public function setTitle($title) { doesn't need the second argument any more.

Can't quite parse how this is major, but it's removing dead code so it's a legit bug fix.

Committed and pushed to 8.0.x. Thanks!