The calls to field_info_instances() seem unnecessary and these functions are used quite a lot.

CommentFileSizeAuthor
#5 2213719-speedup-item-to-entity-to-item.patch7.06 KBdave reid
#3 2213719-speedup-item-to-entity-to-item.patch4.56 KBdave reid
#1 2213719-speedup-item-to-entity-to-item.patch4.6 KBdave reid

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
StatusFileSize
new 2213719-speedup-item-to-entity-to-item.patch4.6 KB

Status: Needs review » Needs work

The last submitted patch, 1: 2213719-speedup-item-to-entity-to-item.patch, failed testing.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2213719-speedup-item-to-entity-to-item.patch4.56 KB

Try again.

Status: Needs review » Needs work

The last submitted patch, 3: 2213719-speedup-item-to-entity-to-item.patch, failed testing.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2213719-speedup-item-to-entity-to-item.patch7.06 KB

Fixed the tests. This simply changed the order in which the 'id' key appears in the field value.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Fixed

Committed #5 to 7.x-1.x: http://drupalcode.org/project/multifield.git/commit/e6c641e

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.