WebTestBase::drupalCreateNode() shouldn't imply you can set 'changed' time. [#2213411]

API page: https://api.drupal.org/api/drupal/core%21modules%21simpletest%21lib%21Dr...

Enter a descriptive title (above) relating to protected function WebTestBase::drupalCreateNode, then describe the problem you have found:

The documentation and code for WebTestBase::drupalCreateNode() says that you can set $settings['changed'] to a value and it will be set on the node.

This is not correct. See Node::preSave() -- it always sets the value of changed to the request time, which in a test is always when you started the test (constant for all nodes created during the test, and nothing you can do about it as far as I can tell).

We should just take the 'changed' attribute out of the documentation and code of WebTestBase, unless we are allowed to fix Node::preSave() so that it only sets 'changed' if it wasn't already set to a value.

Comment	File	Size	Author
#4	2213411-simple-fix-4.patch	933 bytes	jhodgdon
#4
#2	2213411-simple-fix.patch	919 bytes	jhodgdon
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

tim.plunkett

he/him

English

Philadelphia

CreditAttribution: tim.plunkett commented 7 March 2014 at 23:58

Yep, see #722688: Allow programmatic setting of node->changed and #322759: Allow hook_node_presave() to alter other node fields for historical issues about this.

We needed to test the sorting of this for /admin/content, and to work around that we had to do this:

class NodeAdminTest {
  function testContentAdminSort() {
    $this->drupalLogin($this->admin_user);

    $changed = REQUEST_TIME;
    foreach (array('dd', 'aa', 'DD', 'bb', 'cc', 'CC', 'AA', 'BB') as $prefix) {
      $changed += 1000;
      $node = $this->drupalCreateNode(array('title' => $prefix . $this->randomName(6)));
      db_update('node_field_data')
        ->fields(array('changed' => $changed))
        ->condition('nid', $node->id())
        ->execute();
    }